-Wunused-but-set-variable post-increments found by new Clang trunk (number 3 will shock you!) #13304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found with -Wunused-but-set-variable on Clang trunk Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Signed-off-by: Ahelenia Ziemiańska <[email protected]>
…ader fails Found with -Wunused-but-set-variable on Clang trunk Signed-off-by: Ahelenia Ziemiańska <[email protected]>
nabijaczleweli
force-pushed
the
why-does-mom-let-you-play-with-new-clang
branch
from
158d8d0 to
741925e
Compare
behlendorf
approved these changes
Apr 11, 2022
…ARC header Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
nabijaczleweli
force-pushed
the
why-does-mom-let-you-play-with-new-clang
branch
from
741925e to
d1bc3c6
Compare
behlendorf
pushed a commit
that referenced
this pull request
Apr 13, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #13304
behlendorf
pushed a commit
that referenced
this pull request
Apr 13, 2022
…ader fails Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #13304
behlendorf
pushed a commit
that referenced
this pull request
Apr 13, 2022
…ARC header Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #13304
behlendorf
pushed a commit
that referenced
this pull request
Apr 13, 2022
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #13304
nabijaczleweli
added a commit
to nabijaczleweli/zfs
that referenced
this pull request
Apr 13, 2022
…ader fails Found with -Wunused-but-set-variable on Clang trunk Upstream-commit: a4e0cee Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
Merged
13 tasks
nabijaczleweli
added a commit
to nabijaczleweli/zfs
that referenced
this pull request
Apr 13, 2022
…ader fails Found with -Wunused-but-set-variable on Clang trunk Upstream-commit: a4e0cee Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
behlendorf
pushed a commit
that referenced
this pull request
Apr 15, 2022
…ader fails Found with -Wunused-but-set-variable on Clang trunk Upstream-commit: a4e0cee Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #13304
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
…ader fails Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
…ARC header Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
…ader fails Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
…ARC header Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
nicman23
pushed a commit
to nicman23/zfs
that referenced
this pull request
Aug 22, 2022
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 2, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 2, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
…ader fails Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
…ARC header Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
…ader fails Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
…ARC header Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
…ader fails Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
…ARC header Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
…ader fails Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
…ARC header Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 23, 2022
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
szubersk
pushed a commit
to szubersk/zfs
that referenced
this pull request
Nov 16, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304 (cherry picked from commit 63cb341)
szubersk
pushed a commit
to szubersk/zfs
that referenced
this pull request
Nov 16, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304 (cherry picked from commit 16c3290)
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 29, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 29, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 30, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 30, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 1, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 1, 2022
Found with -Wunused-but-set-variable on Clang trunk Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal") Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304
szubersk
pushed a commit
to szubersk/zfs
that referenced
this pull request
Dec 7, 2022
Found with -Wunused-but-set-variable on Clang trunk Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#13304 (cherry picked from commit 63cb341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We provide no API for draid, it did nothing, and was undocumented.
num_indirectis a left-over from the original a1d477c; it's unused there as well.zpool_clear_label()contains a bug-fix (since I assume failing to clear the L2ARC label should be an error) an optimisation, and a clean-up to match the bug-fix. The bug-fix is separate for backports.How Has This Been Tested?
Builds.
Types of changes
Checklist:
Signed-off-by.